[3.9] bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (GH-25595) #25725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and tabs. (pythonGH-25595) * issue43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 76cd81d) Co-authored-by: Senthil Kumaran <senthil@uthcode.com>
|
@orsenthil: Status check is done, and it's a success ✅ . |
|
@orsenthil: Status check is done, and it's a success ✅ . |
orsenthil
approved these changes
Apr 29, 2021
orsenthil
approved these changes
Apr 29, 2021
|
@orsenthil: Status check is done, and it's a failure ❌ . |
mlissner
added a commit
to freelawproject/courtlistener
that referenced
this pull request
Apr 30, 2021
This goes to show that messing with security-critical code is a nasty
business and often a mistake. Luckily, we have tests, but what
happened here is that I tweaked the code to separate out checks from
redirection. In so doing, I removed pulled the quoting code into the
checks, but took it out of the redirection part. So previously, we'd
quote a URL before redirecting it, now we didn't.
To fix this, I copied the fix from Python's standard lib that you can
see here:
python/cpython#25725
Instead of quoting it, we just make sure it doesn't have newlines. If
it does, we bail.
gentoo-bot
pushed a commit
to gentoo/cpython
that referenced
this pull request
May 2, 2021
…newline and tabs. (pythonGH-25595) (pythonGH-25725) * bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs. (pythonGH-25595) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> (cherry picked from commit 76cd81d) Co-authored-by: Senthil Kumaran <skumaran@gatech.edu> (backported to Python 2.7 by Michał Górny)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Gregory P. Smith greg@krypto.org
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
(cherry picked from commit 76cd81d)
Co-authored-by: Senthil Kumaran senthil@uthcode.com
https://bugs.python.org/issue43882