Skip to content

bpo-43995: Fix test_grammar #25764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 30, 2021

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 30, 2021

@pablogsal, does this belong in issue 43901?

@erlend-aasland erlend-aasland changed the title Fix ref leak in test_grammar Fix test_grammar Apr 30, 2021
@erlend-aasland erlend-aasland changed the title Fix test_grammar bpo-43995: Fix test_grammar Apr 30, 2021
@erlend-aasland
Copy link
Contributor Author

FYI, Azure Pipelines failure is unrelated.

@pablogsal
Copy link
Member

@pablogsal, does this belong in issue 43901?

Yeah, but having an issue for this is also ok. Can you leave a comment in 43901 regarding this fix?

@pablogsal
Copy link
Member

Thanks a lot @erlend-aasland !

@erlend-aasland erlend-aasland deleted the ref-leak-grammar branch April 30, 2021 23:25
@erlend-aasland
Copy link
Contributor Author

Thank you, @pablogsal! I'll add a short note about this at 43901 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants