bpo-43434: Move sqlite3.connect audit events to sqlite3.Connection.__init__ #25818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@berkerpeksag: I'm not sure if we should change the docs. Explicitly using the |
|
cc. @zooba |
|
@pablogsal Is it possible to get this into beta1? It contains a bugfix for GH-25246. |
|
Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @erlend-aasland and @zooba, I could not cleanly backport this to |
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
May 2, 2021
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
May 2, 2021
…ion.__init__ (pythonGH-25818). (cherry picked from commit c96cc08) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-25822 is a backport of this pull request to the 3.9 branch. |
zooba
pushed a commit
that referenced
this pull request
May 2, 2021
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
May 2, 2021
…ion.__init__ (pythonGH-25818). (cherry picked from commit c96cc08) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
zooba
pushed a commit
that referenced
this pull request
May 2, 2021
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 2, 2021
…nit__ (pythonGH-25818) (cherry picked from commit ad73d16) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both sqlite3.connect() and sqlite.Connection() now produce sqlite3.connect* events.
https://bugs.python.org/issue43434