Skip to content

[3.9] bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__ (GH-25818) #25822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2021
Merged

[3.9] bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__ (GH-25818) #25822

merged 3 commits into from
May 2, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 2, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit c96cc08)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue43434

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2021 •
edited
Loading

@zooba I kept the tests. Let me know if I should remove them, as they were not present in 3.9.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2021 •
edited
Loading

@zooba Let me remove them; those PR's were not backported. Give me one minute.

UPDATE: Done!

[3.9] bpo-43434: Move sqlite3.connect audit events to sqlite3.Connect…
31959fb 
…ion.__init__ (pythonGH-25818).

(cherry picked from commit c96cc08)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland force-pushed the backport-c96cc08-3.9 branch from bcd1325 to 31959fb Compare May 2, 2021 21:51
@zooba zooba changed the title [3.9] bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__ [3.9] bpo-43434: Move sqlite3.connect audit event to sqlite3.Connection.__init__ (GH-25818) May 2, 2021
@bedevere-bot bedevere-bot mentioned this pull request May 2, 2021
Merged
@erlend-aasland
Copy link
Contributor Author

There's a tiny spelling bug in the NEWS entry (were => was). I'll push a commit to fix it, if you don't mind.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2021 •
edited
Loading

I did the cherry-picking for 3.8 from the commit in main, iso. this one. Hope that's ok.

@erlend-aasland
Copy link
Contributor Author

BTW, I'm logging off for tonight. If there's an issue, I'll look at it first thing in the morning.

@zooba zooba merged commit ad73d16 into python:3.9 May 2, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ad73d1657ca3591b1dd1d15bb80ce83ca7fc3223 3.8

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the backport-c96cc08-3.9 branch May 2, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @miss-islington @zooba @the-knights-who-say-ni @bedevere-bot