Skip to content

bpo-43434: Clean up after GH-25818 #25823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2021
Merged

bpo-43434: Clean up after GH-25818 #25823

merged 1 commit into from
May 2, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 2, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

cc. @zooba

@zooba zooba added the skip news label May 2, 2021
zooba
zooba approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not require backporting, as the backport of the original issue has the changes already applied.

Whoever merges should make the commit message a little more detailed.

@erlend-aasland
Copy link
Contributor Author

Thanks, @zooba. How about "Remove variable and if statement made redundant in GH-25818"

BTW, the macOS test failure is unrelated (spurious ssl failure).

@zooba zooba merged commit cbb7b9e into python:master May 2, 2021
@zooba
Copy link
Member

zooba commented May 2, 2021

I think having a reference to the function that was changed will be more helpful for searching later.

@erlend-aasland erlend-aasland deleted the cleanup branch May 2, 2021 22:20
@erlend-aasland
Copy link
Contributor Author

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @zooba @the-knights-who-say-ni @bedevere-bot