Skip to content

docs: clearly document that ":#X" string formatting results in "0X..." #25941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2021
Merged

docs: clearly document that ":#X" string formatting results in "0X..." #25941

merged 2 commits into from
May 6, 2021

Conversation

taleinat
Copy link
Contributor

@taleinat taleinat commented May 6, 2021

This is a replacement for the closed PR GH-19332.

@taleinat taleinat requested a review from orsenthil May 6, 2021 12:56
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 6, 2021
@taleinat taleinat mentioned this pull request May 6, 2021
Closed
orsenthil
orsenthil approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@orsenthil orsenthil merged commit 92ceb1c into python:main May 6, 2021
@miss-islington
Copy link
Contributor

Thanks @taleinat for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 6, 2021
@taleinat @miss-islington
docs: clearly document that ":GH-X" string formatting results in "0X.…
78af4be 
….." (pythonGH-25941)

* clearly document that ":GH-X" string formatting results in "0X..."

* put back the "serial comma"
(cherry picked from commit 92ceb1c)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 6, 2021
@bedevere-bot
Copy link

GH-25954 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 6, 2021
@taleinat @miss-islington
docs: clearly document that ":GH-X" string formatting results in "0X.…
e1a3544 
….." (pythonGH-25941)

* clearly document that ":GH-X" string formatting results in "0X..."

* put back the "serial comma"
(cherry picked from commit 92ceb1c)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
@bedevere-bot
Copy link

GH-25955 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 6, 2021
miss-islington added a commit that referenced this pull request May 6, 2021
@miss-islington @taleinat
docs: clearly document that ":GH-X" string formatting results in "0X.…
34fc6dd 
….." (GH-25941)

* clearly document that ":GH-X" string formatting results in "0X..."

* put back the "serial comma"
(cherry picked from commit 92ceb1c)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 6, 2021
@miss-islington @taleinat
docs: clearly document that ":GH-X" string formatting results in "0X.…
1326f51 
….." (GH-25941)

* clearly document that ":GH-X" string formatting results in "0X..."

* put back the "serial comma"
(cherry picked from commit 92ceb1c)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@taleinat @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni