Skip to content

Doc: http.server: directory is not a class attribute, but an argument. #26017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2021
Merged

Doc: http.server: directory is not a class attribute, but an argument. #26017

merged 2 commits into from
May 11, 2021

Conversation

JulienPalard
Copy link
Member

Also added the fact that this argument was added on 3.7.

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 10, 2021
orsenthil
orsenthil approved these changes May 11, 2021
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@orsenthil orsenthil added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 11, 2021
@orsenthil orsenthil merged commit d1b8157 into python:main May 11, 2021
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @JulienPalard and @orsenthil, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker d1b81574edd75e33ae85c525ac988ce772675a07 3.10

@bedevere-bot
Copy link

GH-26030 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 11, 2021
@JulienPalard @miss-islington
Doc: http.server: directory is not a class attribute, but an argument. (
1a4b398 
pythonGH-26017)

* Doc: http.server: directory is not a class attribute, but an argument.
(cherry picked from commit d1b8157)

Co-authored-by: Julien Palard <julien@palard.fr>
orsenthil pushed a commit that referenced this pull request May 11, 2021
@miss-islington @JulienPalard
Doc: http.server: directory is not a class attribute, but an argument. (
1d8c180 
GH-26017) (GH-26030)

* Doc: http.server: directory is not a class attribute, but an argument.
(cherry picked from commit d1b8157)

Co-authored-by: Julien Palard <julien@palard.fr>

Co-authored-by: Julien Palard <julien@palard.fr>
@orsenthil orsenthil added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels May 11, 2021
@miss-islington
Copy link
Contributor

Thanks @JulienPalard for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-26031 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 11, 2021
miss-islington added a commit that referenced this pull request May 11, 2021
@miss-islington @JulienPalard
Doc: http.server: directory is not a class attribute, but an argument. (
9090401 
GH-26017)

* Doc: http.server: directory is not a class attribute, but an argument.
(cherry picked from commit d1b8157)

Co-authored-by: Julien Palard <julien@palard.fr>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@JulienPalard JulienPalard deleted the mdk/http.server/directory branch October 9, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees

@orsenthil orsenthil

Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JulienPalard @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni