[3.8] bpo-44114: Fix dictkeys_reversed and dictvalues_reversed function signatures (GH-26062) #26094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…natures (pythonGH-26062) These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter. This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking. (cherry picked from commit ab383eb) Co-authored-by: Joe Marshall <joe.marshall@nottingham.ac.uk>
|
@joemarshall and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
2 similar comments
|
@joemarshall and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
|
@joemarshall and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
serhiy-storchaka
approved these changes
May 13, 2021
|
@joemarshall and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
|
Since it's too late for 3.8, should this be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are passed and called as PyCFunction, however they are defined here without the (ignored) args parameter.
This works fine in some C compilers, but fails in webassembly or anything else that has strict function pointer call type checking.
(cherry picked from commit ab383eb)
Co-authored-by: Joe Marshall joe.marshall@nottingham.ac.uk
https://bugs.python.org/issue44114