Skip to content

gh-84632: IDLE: fix clipboard being cleared upon exit #26163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+52 −4
Open

gh-84632: IDLE: fix clipboard being cleared upon exit #26163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc3fb61
bpo-40452: IDLE: fix clipboard being cleared upon exit
taleinat May 16, 2021
64d1966
Merge branch 'main' into bpo-40452/IDLE-preserve-clipboard-upon-exit
taleinat May 16, 2021
a4d77ba
rename to _tkinter._finalize_tcl
taleinat May 16, 2021
6d098ac
reword NEWS entry as per CR
taleinat May 17, 2021
bb4835c
use try/finally to ensure pyshell cleanups are executed
taleinat May 19, 2021
9d45039
Merge branch 'main' into bpo-40452/IDLE-preserve-clipboard-upon-exit
taleinat Jul 6, 2021
a6032be
Merge branch 'main' into bpo-40452/IDLE-preserve-clipboard-upon-exit
terryjreedy Sep 18, 2022
13ac9af
Merge branch 'main' into bpo-40452/IDLE-preserve-clipboard-upon-exit
arhadthedev Apr 9, 2023
f3afda8
Run Argument Clinic
arhadthedev Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1688,9 +1688,15 @@ def main():
if prefer_tabs_preference_warning:
shell.show_warning(prefer_tabs_preference_warning)

while flist.inversedict: # keep IDLE running while files are open.
root.mainloop()
root.destroy()
try:
while flist.inversedict: # keep IDLE running while files are open.
root.mainloop()
finally:
try:
root.destroy()
finally:
import _tkinter
_tkinter._finalize_tcl()
capture_warnings(False)

if __name__ == "__main__":
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/IDLE/2021-05-16-16-24-31.bpo-40452.Nayfdf.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix new clipboard content copied from IDLE being gone after exiting IDLE.
19 changes: 19 additions & 0 deletions Modules/_tkinter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3039,6 +3039,24 @@ _tkinter_getbusywaitinterval_impl(PyObject *module)
return Tkinter_busywaitinterval;
}

/*[clinic input]
_tkinter._finalize_tcl

Finalize the Tcl interpreter.

This should be called just before an app exits, to allow Tcl to
execute its own finalization logic. After this, tkinter can no
longer be used, and attempts to do so will result in errors.
[clinic start generated code]*/

static PyObject *
_tkinter__finalize_tcl_impl(PyObject *module)
/*[clinic end generated code: output=a7a2a4c67f43bd28 input=e1082c1b262a40aa]*/
{
Tcl_FinalizeThread();
Py_RETURN_NONE;
}

#include "clinic/_tkinter.c.h"

static PyMethodDef Tktt_methods[] =
Expand Down Expand Up @@ -3122,6 +3140,7 @@ static PyMethodDef moduleMethods[] =
_TKINTER_CREATE_METHODDEF
_TKINTER_SETBUSYWAITINTERVAL_METHODDEF
_TKINTER_GETBUSYWAITINTERVAL_METHODDEF
_TKINTER__FINALIZE_TCL_METHODDEF
{NULL, NULL}
};

Expand Down
24 changes: 23 additions & 1 deletion Modules/clinic/_tkinter.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.