Skip to content

[3.8] bpo-44022: Improve the regression test. (GH-26503) #26506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

[3.8] bpo-44022: Improve the regression test. (GH-26503) #26506

merged 1 commit into from
Jul 12, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 3, 2021 •
edited
Loading

It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue44022

Automerge-Triggered-By: GH:gpshead

@gpshead @miss-islington
bpo-44022: Improve the regression test. (pythonGH-26503)
730fc95 
It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab84)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot bedevere-bot mentioned this pull request Jun 3, 2021
Merged
@bedevere-bot bedevere-bot added skip news type-security A security issue tests Tests in the Lib/test dir awaiting review labels Jun 3, 2021
@miss-islington
Copy link
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 4, 2021
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 5, 2021
@ambv ambv merged commit 0389426 into python:3.8 Jul 12, 2021
@bedevere-bot
Copy link

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington miss-islington deleted the backport-e60ab84-3.8 branch July 12, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-security A security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @bedevere-bot @gpshead @ambv @the-knights-who-say-ni