Skip to content

[3.8] bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite (GH-26542) #26670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2021
Merged

[3.8] bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite (GH-26542) #26670

merged 1 commit into from
Jun 12, 2021

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 11, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo Pablogsal@gmail.com

https://bugs.python.org/issue38323

@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
5c750ad 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington miss-islington requested a review from gpshead as a code owner June 11, 2021 09:32
@bedevere-bot bedevere-bot mentioned this pull request Jun 11, 2021
Merged
@miss-islington
Copy link
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .

3 similar comments
@miss-islington
Copy link
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@pablogsal: Status check is done, and it's a success ✅ .

@vstinner
Copy link
Member

Even if the 3.8 branch no longer accepts bugfixes, Refleak buildbot workers are still run on this branch: "scheduler: 3.8-daily". Example of job: aarch64 RHEL8 Refleaks 3.8.
https://buildbot.python.org/all/#/builders/225

I propose to backport the test_asyncio fix to prevent the test suite to hang randomly after 3 hours: https://bugs.python.org/issue38323

Maybe the buildbot configuration should be modified to no longer run the 3.8 branch. In this case, we don't need this backport (the hang is random and unlikely).

cc @ambv @pablogsal @zware

@ambv
Copy link
Contributor

ambv commented Jun 11, 2021

I am fine with this backport if it keeps 3.8 refleak tests running.

@pablogsal pablogsal merged commit af5fb67 into python:3.8 Jun 12, 2021
@miss-islington miss-islington deleted the backport-f171877-3.8 branch June 12, 2021 17:45
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @vstinner @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot