-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
bpo-12022: Change error type for bad objects in "with" and "async with" #26809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-12022: Change error type for bad objects in "with" and "async with" #26809
Conversation
A TypeError is now raised instead of an AttributeError in "with" and "async with" statements for objects which do not support the context manager or asynchronous context manager protocols correspondingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support the idea.
For the code, why not pass the message format string to special_lookup() instead of repeating the same code four times?
Also I think it would be useful to know which attribute is missing.
It would save 3 lines in every of 4 caller places, but the helper function adds 14 lines. Also, I think that in future we can add slots for these methods, this will make the common code so simple that there will be nothing to share.
I think that in most cases the error is in using wrong object rather than missing of some dunder methods in the definition of user class. Traditional error messages:
It does not say But it may be worth to add a hint in case of the object that has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, LG then!
A TypeError is now raised instead of an AttributeError in
"with" and "async with" statements for objects which do not
support the context manager or asynchronous context manager
protocols correspondingly.
https://bugs.python.org/issue12022