bpo-39452: rewrite and expand __main__.rst #26883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Related bpo's: 17359, 24632, 38452
|
is it worth mentioning runpy? |
graingert
reviewed
Jun 29, 2021
graingert
approved these changes
Jun 29, 2021
graingert
reviewed
Jun 29, 2021
I think so! It's been mentioned; see 4c60f2c |
graingert
reviewed
Jun 30, 2021
graingert
reviewed
Jun 30, 2021
merwok
reviewed
Jun 30, 2021
merwok
reviewed
Aug 24, 2021
merwok
reviewed
Aug 24, 2021
|
OK, at this point I made all the edits I wanted. Look like @merwok did a pass on that already. If I don't hear back by end of day today, I'll be merging that. Huge improvement over the status quo, thanks for your hard work @jdevries3133. |
merwok
reviewed
Aug 24, 2021
|
I have noted various small things, but don’t have the time to do an overarching review of all changes. So I’m glad you picked up my request for review and did an editing pass so that this contribution can be merged! Thanks for your and Jack’s efforts on this! |
|
Thanks @jdevries3133 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
@ambv: Please replace |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 24, 2021
Broadened scope of the document to explicitly discuss and differentiate between ``__main__.py`` in packages versus the ``__name__ == '__main__'`` expression (and the idioms that surround it), as well as ``import __main__``. Co-authored-by: Géry Ogam <gery.ogam@gmail.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 7cba231) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
|
GH-27932 is a backport of this pull request to the 3.10 branch. |
|
So cool to see the PSF finally funding development work directly.
Kind regards,
Steve
…On Tue, Aug 24, 2021 at 6:01 PM Łukasz Langa ***@***.***> wrote:
Merged #26883 <#26883> into main.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#26883 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZWYFBGUIEZOSJ2QMGV73T6PGADANCNFSM47GN2KLQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
miss-islington
added a commit
that referenced
this pull request
Aug 24, 2021
Broadened scope of the document to explicitly discuss and differentiate between ``__main__.py`` in packages versus the ``__name__ == '__main__'`` expression (and the idioms that surround it), as well as ``import __main__``. Co-authored-by: Géry Ogam <gery.ogam@gmail.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 7cba231) Co-authored-by: Jack DeVries <58614260+jdevries3133@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am picking up the torch on 39452, continuing where @maggyero left off, and
also implementing
my discourse proposal,
which seemed to be well-liked.
https://bugs.python.org/issue39452