Skip to content

bpo-44558: Make the implementation consistency of operator.indexOf #27012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2021
Merged

bpo-44558: Make the implementation consistency of operator.indexOf #27012

merged 2 commits into from
Jul 5, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jul 4, 2021 •
edited by bedevere-bot
Loading

@corona10 corona10 force-pushed the bpo-44558-index-of branch from af82eb3 to 776a54a Compare July 4, 2021 12:23
@corona10 corona10 changed the title bpo-44558: Make consistency of the implementation of operator.indexOf bpo-44558: Make the implementation consistency of operator.indexOf Jul 4, 2021
@corona10 corona10 force-pushed the bpo-44558-index-of branch from 776a54a to b9da2e2 Compare July 4, 2021 12:24
@corona10 corona10 added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jul 4, 2021
@corona10 corona10 requested a review from vstinner July 4, 2021 12:41
@Rupt Rupt mentioned this pull request Jul 4, 2021
Merged
@corona10 corona10 requested a review from serhiy-storchaka July 4, 2021 13:24
serhiy-storchaka
serhiy-storchaka approved these changes Jul 5, 2021
View reviewed changes
Lib/test/test_operator.py
Comment on lines +191 to +192
nan = float("nan")
self.assertEqual(operator.indexOf([nan, nan, 21], nan), 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a test for {} as in #27007.

@corona10 corona10 merged commit 0930240 into python:main Jul 5, 2021
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2021
@corona10 @miss-islington
bpo-44558: Make the implementation consistency of operator.indexOf (p…
7ddd0ec 
…ythonGH-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot
Copy link

GH-27029 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 5, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2021
@corona10 @miss-islington
bpo-44558: Make the implementation consistency of operator.indexOf (p…
6dc40c4 
…ythonGH-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot
Copy link

GH-27030 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jul 5, 2021
miss-islington added a commit that referenced this pull request Jul 5, 2021
@miss-islington @corona10
bpo-44558: Make the implementation consistency of operator.indexOf (G…
1f8486f 
…H-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington added a commit that referenced this pull request Jul 5, 2021
@miss-islington @corona10
bpo-44558: Make the implementation consistency of operator.indexOf (G…
9f47d87 
…H-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni