Note that before merging, this should be run with builds on other OSes like Aix, FreeBSD, etc.

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 624093b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

For reviewing: note that the code block wrapped in try/except is unchanged except for indentation.

🤖 New build scheduled with the buildbot fleet by @gpshead for commit b2a681b 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Thanks @akulakov for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

GH-27081 is a backport of this pull request to the 3.10 branch.

GH-27082 is a backport of this pull request to the 3.9 branch.

@gpshead Thanks for the review :)

This now raises a wrong FileNotFoundError when the src is a directory because only the dst existance is checked.

This now raises a wrong FileNotFoundError when the src is a directory because only the dst existance is checked.

FileNotFoundError is a common exception for "file or directory does not exist". If you feel it's wrongly raised in some scenario, please open a new issue on bugs.python.org and add an example and expected / observed output.

But the path exists. It only is a directory. This PR changed the correct IsADirectoryError to a now incorrect FileNotFoundError for that case

@Flamefire I think you're right, I can reproduce it. I will reopen the issue.

I opened https://bugs.python.org/issue45234 but mentioned the new failure in 43219