Skip to content

[3.10] bpo-44490: Partially backport GH-26980's refactoring for easier bugfix backports #27203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jul 17, 2021

…ugfix backports

Co-Authored-By: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
Co-Authored-By: Guido van Rossum <gvanrossum@gmail.com>
Co-Authored-By: Yurii Karabas <1998uriyyo@gmail.com>
@Fidget-Spinner Fidget-Spinner changed the title [3.10] bpo-44490: Partially backport refactor of GH-26980 for easier bugfix backports [3.10] bpo-44490: Partially backport GH-26980's refactoring for easier bugfix backports Jul 17, 2021
@Fidget-Spinner
Copy link
Member Author

This is mainly for Serhiy's planned refactoring (see GH-27196). I did not backport any of the new features, only the code refactoring.

@Fidget-Spinner
Copy link
Member Author

Hmm I don't understand the failure in Tests / Check if the ABI has changed (pull_request):

2 Removed functions:

  'function PyObject* _Py_make_parameters(PyObject*)'    {_Py_make_parameters}
  'function PyObject* _Py_subs_parameters(PyObject*, PyObject*, PyObject*, PyObject*)'    {_Py_subs_parameters}

These functions are newly added, how can they be removed?

@serhiy-storchaka
Copy link
Member

I do not think it is needed for backporting of GH-27196. GH-27196 almost do not touch genericaliasobject.c, so conflicts are minimal.

It would nice to backport indexing.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Jul 17, 2021

I do not think it is needed for backporting of GH-27196. GH-27196 almost do not touch genericaliasobject.c, so conflicts are minimal.

You're right that most things should backport cleanly. It's only required if you want to backport shifting or using _Py_subs_parameters and _Py_make_parameters. Those don't exist in 3.10 currently.

It would nice to backport indexing.

Yup. Maybe if you review and approve GH-26980, Pablo will allow us to backport it to 3.10.

@Fidget-Spinner
Copy link
Member Author

Closing this since GH-27207 has been approved.

@Fidget-Spinner Fidget-Spinner deleted the backport_union_refactoring branch July 19, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants