-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
bpo-42064: Pass module state to sqlite3
UDF callbacks
#27456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-42064: Pass module state to sqlite3
UDF callbacks
#27456
Conversation
A couple of questions, @encukou:
|
There are very few funcitons in the C-API that you can call without the GIL held; usually they're the ones needed before a GIL is created. For |
Yes, I've seen it ;) But then why does this PR work as it is? (That is, without the GIL) (FYI: I'll update the PR with GIL wrappers soon) |
I assume it's because you're not using multiple threads. |
Ah, right. Thanks! I've updated the PR. PTAL :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some more questionable uses of the GIL in existing code (see the issue). But let's not block this PR; it is an improvement.
Thanks for reviewing! |
https://bugs.python.org/issue42064
Automerge-Triggered-By: GH:encukou