bpo-43468: Per instance locking for functools.cached_property #27609
+71
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like |
ambv
reviewed
Aug 17, 2021
| @@ -18,7 +18,7 @@ | |||
| from collections import namedtuple | |||
| # import types, weakref # Deferred to single_dispatch() | |||
| from reprlib import recursive_repr | |||
| from _thread import RLock | |||
| from threading import RLock, Condition, get_ident | |||
There was a problem hiding this comment.
This change introduces an import cycle which causes tests to fail.
There was a problem hiding this comment.
There is a race condition on 980-983.
Scenario:
- 3 threads, 1 registered in
updaters - 2nd and 3rd will wait
- both waiting threads will see registration of registered thread disappear
Mutual exclusion breaks.
ptmcg
reviewed
Aug 27, 2021
Misc/NEWS.d/next/Library/2021-08-04-18-30-25.bpo-43468.PlU--J.rst
Outdated
Show resolved
Hide resolved
|
Can someone confirm or deny if my solution on twitter works?
I also made a PR here: rhettinger#7 |
candidate fix for deadlock
|
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR. It needs a NEWS entry, perhaps more tests, and perhaps some more factoring.
https://bugs.python.org/issue43468