Skip to content

bpo-44997: macOS does not support loadable SQLite extensions #27979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

bpo-44997: macOS does not support loadable SQLite extensions #27979

merged 1 commit into from
Aug 27, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 26, 2021 •
edited by bedevere-bot
Loading

bpo-44997: macOS does not support loadable SQLite extensions
879fc7f 
Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Aug 26, 2021 •
edited
Loading

I applied skip news for this. Scream out if you disagree, @ronaldoussoren.

Also, I'd say backport to 3.10, maybe even 3.9. Let me know if you agree.

@ronaldoussoren
Copy link
Contributor

Skipnews should be fine.

Is the error message clear enough? I don't think it is necessary to mention the configure flag here because you have to explicitly opt in to loadable extensions to get this error.

ronaldoussoren
ronaldoussoren approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland
Copy link
Contributor Author

Is the error message clear enough? I don't think it is necessary to mention the configure flag here because you have to explicitly opt in to loadable extensions to get this error.

Yes, I agree.

@erlend-aasland
Copy link
Contributor Author

Do you agree that we should backport this?

@erlend-aasland
Copy link
Contributor Author

cc. @pablogsal regarding backporting, as he is the release manager.

@ambv
Copy link
Contributor

ambv commented Aug 27, 2021

I want this in 3.9 so it has to go to 3.10 too. Pablo can decide if it fits for 3.10.0rc2 or 3.10.1.

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Aug 27, 2021
@ambv ambv merged commit 2ec9428 into python:main Aug 27, 2021
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2021
@miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (pythonG…
644a954 
…H-27979)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

GH-27994 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 27, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2021
@miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (pythonG…
a329671 
…H-27979)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Aug 27, 2021
@bedevere-bot
Copy link

GH-27995 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-27996 is a backport of this pull request to the 3.8 branch.

@erlend-aasland erlend-aasland deleted the sqlite-no-extensions-for-you branch August 27, 2021 11:01
@erlend-aasland
Copy link
Contributor Author

Thanks, @ambv! I'm sorry, I should've CC'd you as well regarding backports.

ambv pushed a commit that referenced this pull request Aug 27, 2021
@miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)…
9c74678 
… (GH-27996)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit that referenced this pull request Aug 27, 2021
@miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)
baa8d48 
Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv pushed a commit that referenced this pull request Aug 27, 2021
@miss-islington
bpo-44997: macOS does not support loadable SQLite extensions (GH-27979)…
9500dd5 
… (GH-27995)

Authored-by: Ronald Oussoren <ronaldoussoren@mac.com>
(cherry picked from commit 2ec9428)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
fbordignon pushed a commit to fbordignon/python-cmake-buildsystem that referenced this pull request Nov 9, 2021
On Linux, uses external libffi for python >= 3.7
f12e318 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
jcfr pushed a commit to jcfr/python-cmake-buildsystem that referenced this pull request Jan 5, 2022
@jcfr
On Linux, uses external libffi for python >= 3.7
f8c152d 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
jcfr pushed a commit to jcfr/python-cmake-buildsystem that referenced this pull request Jan 6, 2022
@jcfr
On Linux, uses external libffi for python >= 3.7
1a8ffa0 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
jcfr pushed a commit to jcfr/python-cmake-buildsystem that referenced this pull request Jan 7, 2022
@jcfr
**WIP** On Linux, uses external libffi for python >= 3.7
5a0611e 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
@mcc-devel mcc-devel mannequin mentioned this pull request May 16, 2022
Closed
dand-oss pushed a commit to dand-oss/python-cmake-buildsystem that referenced this pull request Jun 5, 2022
On Linux, uses external libffi for python >= 3.7
f044a43 
Since python/cpython@f40d4ddff (Closes python/cpython#27979: Remove
bundled copy of libffi), external version of libffi is required
on linux.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

@ned-deily ned-deily Awaiting requested review from ned-deily

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@erlend-aasland @ronaldoussoren @ambv @miss-islington @bedevere-bot @the-knights-who-say-ni