bpo-29642: Load tests from implicit packages. #282
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
|
@the-knights-who-say-ni I have completed the above steps. |
Implicit PEP-420-style packages (i.e. missing __init__.py) were omitted, and this commit enables searching for tests in them.
e7322f4 to
1eb074a
Compare
|
I was wrong and it's now outside of my use cases. It can be closed now. |
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jul 1, 2021
Decouple the cleanup logic for initial stubs of sub-interpreters from the stack handling. Previously this logic depended on the value of SLP_CSTACK_GOODGAP being positive.
akruis
added a commit
to akruis/cpython
that referenced
this pull request
Jul 9, 2021
Decouple the cleanup logic for initial stubs of sub-interpreters from the stack handling. Previously this logic depended on the value of SLP_CSTACK_GOODGAP being positive.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unittest.TestLoadersearches for tests only in packages containing__init__.py, although the docs mention that implicit namespace packages (PEP 420) are supported. This PR removes the checks for presence of__init__.pyand therefore enables loading tests from namespace packages.See http://bugs.python.org/issue29642