gh-96910: IDLE - make autocomplete winnconfig handler only trigger once #28332
+17
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… once Before, this was only enforced on the Windows platform, where multiple calls would result in errors. But logically it is the correct behavior, and it allows simplifying the code as well. Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
|
This PR is stale because it has been open for 30 days with no activity. |
|
PR #28328 for bpo-45193 was closed and a simpler fix applied to 3.11 and 3.10, with a fix for 3.9 pending. This should work for 3.11 and .10. I am thinking of backporting a simplified version to 3.9 and not worry that it is not perfect. Closing and opening to see current results. In msg401802 of bpo-45193, I said "I would rather make a more extensive change than to patch a badly written function for at least the fourth time. I will open an issue for [this] PR and explain later." If I cannot soon remember what I meant, I should apply this after more test and review. |
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this was only enforced on the Windows platform, where multiple calls would result in errors. But logically it is the correct behavior, and it allows simplifying the code as well.
This also includes a minor change to correctly use
platform.system() == "Windows"rather than.startswith("Windows").Note that this requires the fix in PR GH-28328 to work properly on Linux.
Also, note that this has no effect on the position of the completion window while scrolling the editor window, which isn't updated anyways as far as I can tell.