Skip to content

bpo-24076: Fix reference in sum() introduced by GH-28469 #28493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2021
Merged

bpo-24076: Fix reference in sum() introduced by GH-28469 #28493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd121ec
bpo-24076: Fix reference in sum() introduced by GH-28469
pablogsal Sep 21, 2021
a79b4bf
Add a comment for the 'continue' case
pablogsal Sep 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2484,7 +2484,8 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
/* Single digits are common, fast, and cannot overflow on unpacking. */
switch (Py_SIZE(item)) {
case -1: b = -(sdigit) ((PyLongObject*)item)->ob_digit[0]; break;
case 0: continue;
// Note: the continue goes to the top of the "while" loop that iterates over the elements
case 0: Py_DECREF(item); continue;
case 1: b = ((PyLongObject*)item)->ob_digit[0]; break;
default: b = PyLong_AsLongAndOverflow(item, &overflow); break;
}
Expand Down