Skip to content

bpo-45020: Default to using frozen modules only on non-debug builds. #28590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpo-45020: Default to using frozen modules only on non-debug builds. #28590

wants to merge 2 commits into from

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Sep 28, 2021 •
edited by bedevere-bot
Loading

This should give us the default we normally want, "on", without disrupting contributors too much. This should be a good-enough place to start. We can adjust the heuristic (e.g. PGO or running-in-source-tree) later if needed.

https://bugs.python.org/issue45020

@ericsnowcurrently ericsnowcurrently added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 28, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 60b8694 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 28, 2021
@ericsnowcurrently
Copy link
Member Author

ericsnowcurrently commented Sep 28, 2021 •
edited
Loading

3 buildbots failed, all non-debug, all with the same failure in idlelib.idle_test.test_help_about.LiveDialogTest.test_printer_buttons (name='license'):

This matches the failures on the Windows checks (which are also non-debug).

@gvanrossum
Copy link
Member

Looks like something is finding a data file (some license) by using __file__?

@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 7, 2021
Closed
46 tasks
@ericsnowcurrently
Copy link
Member Author

I prefer gh-28940, so I'm tabling this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 will be requested when the pull request is marked ready for review FFY00 is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericsnowcurrently @bedevere-bot @gvanrossum @the-knights-who-say-ni