bpo-45339: Allow user to specify Thread class for use with ThreadPoolExecutor #28640
Conversation
Currently the only way to use a custom thread class with the ThreadPoolExecutor is extend the class and override the private method _adjust_thread_count(), which means reproducing (basically, copying and pasting) the body of that method into application code. This change would allow the thread class to be specified when the ThreadPoolExecutor is instantiated, allowing for more composable use.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Hi @erickpeirson could you open an issue on https://bugs.python.org for discussion? 😊 |
|
|
This PR is stale because it has been open for 30 days with no activity. |
| @@ -0,0 +1 @@ | |||
| Currently the only way to use a custom thread class with the ThreadPoolExecutor is extend the class and override the private method _adjust_thread_count(), which means reproducing (basically, copying and pasting) the body of that method into application code. This change would allow the thread class to be specified when the ThreadPoolExecutor is instantiated, allowing for more composable use. | |||
There was a problem hiding this comment.
The NEWS entry should describe the change, not argue for it.
| Currently the only way to use a custom thread class with the ThreadPoolExecutor is extend the class and override the private method _adjust_thread_count(), which means reproducing (basically, copying and pasting) the body of that method into application code. This change would allow the thread class to be specified when the ThreadPoolExecutor is instantiated, allowing for more composable use. | |
| Add ``thread_class`` parameter to `:class:concurrent.futures.ThreadPoolExecutor`. |
|
All commit authors signed the Contributor License Agreement. |
Currently the only way to use a custom thread class with the ThreadPoolExecutor is extend the class and override the private method _adjust_thread_count(), which means reproducing (basically, copying and pasting) the body of that method into application code. This change would allow the thread class to be specified when the ThreadPoolExecutor is instantiated, allowing for more composable use.
I couldn't find anything in https://bugs.python.org covering this particular issue; happy to go back and create one (and beg your forgiveness for jumping the gun).
https://bugs.python.org/issue45339