Skip to content

bpo-45328: Avoid failure in OSs without TCP_NODELAY support #28646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2021
Merged

bpo-45328: Avoid failure in OSs without TCP_NODELAY support #28646

merged 2 commits into from
Oct 6, 2021

Conversation

rtobar
Copy link
Contributor

@rtobar rtobar commented Sep 30, 2021 •
edited by bedevere-bot
Loading

OSs without support for TCP_NODELAY will raise an OSError when trying to
set the socket option, but the show can still go on.

https://bugs.python.org/issue45328

@rtobar
bpo-45328: Avoid failure in OSs without TCP_NODELAY support
59a10e1 
OSs without support for TCP_NODELAY will raise an OSError when trying to
set the socket option, but the show can still go on.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rtobar

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@ambv ambv added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Oct 6, 2021
@ambv ambv merged commit 0571b93 into python:main Oct 6, 2021
@miss-islington
Copy link
Contributor

Thanks @rtobar for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @rtobar and @ambv, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0571b934f5f9198c3461a7b631d7073ac0a5676f 3.10

@bedevere-bot
Copy link

GH-28770 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 6, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2021
@rtobar @miss-islington
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (pythonGH…
758f7e4 
…-28646)

Operating systems without support for TCP_NODELAY will raise an OSError
when trying to set the socket option, but the show can still go on.
(cherry picked from commit 0571b93)

Co-authored-by: rtobar <rtobarc@gmail.com>
@ambv ambv added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Oct 6, 2021
@miss-islington
Copy link
Contributor

Thanks @rtobar for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 6, 2021
@bedevere-bot
Copy link

GH-28771 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2021
@rtobar @miss-islington
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (pythonGH…
c7870ed 
…-28646)

Operating systems without support for TCP_NODELAY will raise an OSError
when trying to set the socket option, but the show can still go on.
(cherry picked from commit 0571b93)

Co-authored-by: rtobar <rtobarc@gmail.com>
ambv pushed a commit that referenced this pull request Oct 6, 2021
@miss-islington @rtobar
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) (
4c35a2a 
GH-28771)

Operating systems without support for TCP_NODELAY will raise an OSError
when trying to set the socket option, but the show can still go on.
(cherry picked from commit 0571b93)

Co-authored-by: rtobar <rtobarc@gmail.com>
ambv pushed a commit that referenced this pull request Oct 6, 2021
@miss-islington @rtobar
bpo-45328: Avoid failure in OSs without TCP_NODELAY support (GH-28646) (
92018a0 
GH-28770)

Operating systems without support for TCP_NODELAY will raise an OSError
when trying to set the socket option, but the show can still go on.
(cherry picked from commit 0571b93)

Co-authored-by: rtobar <rtobarc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ambv ambv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rtobar @the-knights-who-say-ni @miss-islington @bedevere-bot @ambv