bpo-36841: JSONEncoder call self.default for unsupported floats #28648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpo-36841: allows `default` option to override unsupported float behavior, instead of unconditional ValueError.
|
This PR is stale because it has been open for 30 days with no activity. |
|
Somebody has to review it. |
|
Could a unit test be added to show that this change does something that was not possible or broken before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows
defaultoption to override unsupported float behavior, instead of unconditional ValueError.A smaller change than #13233, though the default ValueError is preserved in the default
defaultmethod. Since we already havedefaultfor expanding what can be serialized, it seems to make sense that it would be called for unsupported values.I think the same change needs to be added to the corresponding C code produced by
c_make_encoder, but I haven't found it yet.https://bugs.python.org/issue36841