Skip to content

bpo-45249: Fix caret location when end_offset is set to 0 #28855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2021
Merged

bpo-45249: Fix caret location when end_offset is set to 0 #28855

merged 1 commit into from
Oct 16, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 10, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal mentioned this pull request Oct 10, 2021
Merged
@pablogsal
Copy link
Member Author

CC: @blueyed

@miss-islington miss-islington merged commit fe0d9e2 into python:main Oct 16, 2021
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-28994 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 16, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 16, 2021
@pablogsal @miss-islington
bpo-45249: Fix caret location when end_offset is set to 0 (pythonGH-2…
5694622 
…8855)

(cherry picked from commit fe0d9e2)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Oct 16, 2021
@miss-islington @pablogsal
bpo-45249: Fix caret location when end_offset is set to 0 (GH-28855)
5df35fa 
(cherry picked from commit fe0d9e2)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@akulakov akulakov mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical isidentical approved these changes

@ammaraskar ammaraskar Awaiting requested review from ammaraskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablogsal @miss-islington @bedevere-bot @isidentical @the-knights-who-say-ni