bpo-45640: Tokens are now clickable #29260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before: After: |
|
Thanks @Arthur-Milchior for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-29621 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 18, 2021
Co-authored-by: Łukasz Langa <lukasz@langa.pl> (cherry picked from commit 3295910) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
|
Thanks @Arthur-Milchior for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
|
Sorry, @Arthur-Milchior and @ambv, I could not cleanly backport this to |
ambv
pushed a commit
that referenced
this pull request
Nov 18, 2021
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Nov 18, 2021
Co-authored-by: Łukasz Langa <lukasz@langa.pl>. (cherry picked from commit 3295910) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
|
GH-29623 is a backport of this pull request to the 3.9 branch. |
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-45640: Tokens are now clickable
In the current documentation, production tokens are not clickable. For example in https://docs.python.org/3/reference/expressions.html#yield-expressions , you highlight
yield_fromas a token but do not link to it.I suppose that the goal, when using :token:
yeld_from, was to ensure that the token links to its definition. However, Sphinx require to use :token:~python-grammar:yeld_fromfor the link to appear.I suggest adding ~python-grammar after each token:.
Testing: compiling the doc and checking that the above mentioned token is now a link
https://bugs.python.org/issue45640