Skip to content

[3.9] bpo-45678: Add functools.singledispatchmethod tests (GH-29328) #29391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.9] bpo-45678: Add functools.singledispatchmethod tests (GH-29328) #29391

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 3, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

https://bugs.python.org/issue45678

@AlexWaygood @miss-islington
bpo-45678: Add functools.singledispatchmethod tests (pythonGH-29328)
531de96 
(cherry picked from commit 5a14929)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Nov 3, 2021
@miss-islington
Copy link
Contributor Author

@AlexWaygood and @ambv: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2021
Merged
@AlexWaygood
Copy link
Member

This is fun! @ambv, it appears that attempting to backport these new tests to 3.9 has uncovered a bug in the 3.9 branch, where staticmethod and classmethod singledispatchmethods don't properly wrap the docstrings or names of the target function. Would the best course of action be to:

  1. Abandon backporting this to 3.9?
  2. Apply a bugfix along with the new tests to 3.9, linking to the same BPO issue?
  3. Create a new BPO issue for a bugfix?

@ambv
Copy link
Contributor

ambv commented Nov 3, 2021

Definitely worth fixing. Since you're not a committer (yet?), you won't be able to patch this PR so you can essentially recreate it as part of the fix. The fix can be part of this same BPO.

@AlexWaygood
Copy link
Member

Definitely worth fixing. Since you're not a committer (yet?), you won't be able to patch this PR so you can essentially recreate it as part of the fix. The fix can be part of this same BPO.

Great, I'll get to work on a fix!

@ambv
Copy link
Contributor

ambv commented Nov 4, 2021

Closing in favor of GH-29394.

@ambv ambv closed this Nov 4, 2021
@miss-islington miss-islington deleted the backport-5a14929-3.9 branch November 4, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
awaiting review tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @AlexWaygood @ambv @the-knights-who-say-ni @bedevere-bot