Skip to content

Ensure the str member of the tokenizer is always initialized #29681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

pablogsal
Copy link
Member

No description provided.

@pablogsal pablogsal merged commit 4f006a7 into python:main Nov 21, 2021
@pablogsal pablogsal deleted the tok_str branch November 21, 2021 02:06
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4f006a789a35f5d1a7ef142bd1304ce167392457 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 21, 2021
…ythonGH-29681).

(cherry picked from commit 4f006a7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 21, 2021
@bedevere-bot
Copy link

GH-29683 is a backport of this pull request to the 3.10 branch.

pablogsal added a commit that referenced this pull request Nov 21, 2021
…H-29681). (GH-29683)

(cherry picked from commit 4f006a7)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Arch Linux Asan Debug 3.10 has failed when building commit 07cf66f.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/621/builds/365) and take a look at the build logs.
  4. Check if the failure is related to this commit (07cf66f) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/621/builds/365

Failed tests:

  • test_logging

Failed subtests:

  • test_post_fork_child_no_deadlock - test.test_logging.HandlerTest

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

  • test_unparse: 3 min 16 sec
  • test_concurrent_futures: 3 min 14 sec
  • test_multiprocessing_spawn: 2 min 51 sec
  • test_subprocess: 2 min 50 sec
  • test_tokenize: 2 min 22 sec
  • test_peg_generator: 2 min 9 sec
  • test_lib2to3: 1 min 48 sec
  • test_gdb: 1 min 37 sec
  • test_multiprocessing_forkserver: 1 min 33 sec
  • test_unicodedata: 1 min 30 sec

1 test failed:
test_logging

12 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_tix test_tk test_ttk_guionly test_winconsoleio test_winreg
test_winsound test_zipfile64

1 re-run test:
test_logging

Total duration: 51 min 28 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/buildbot/buildarea/3.10.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_logging.py", line 749, in test_post_fork_child_no_deadlock
    support.wait_process(pid, exitcode=0)
  File "/buildbot/buildarea/3.10.pablogsal-arch-x86_64.asan_debug/build/Lib/test/support/__init__.py", line 1971, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 478210 is still running after 30.0 seconds


Traceback (most recent call last):
  File "/buildbot/buildarea/3.10.pablogsal-arch-x86_64.asan_debug/build/Lib/test/test_logging.py", line 749, in test_post_fork_child_no_deadlock
    support.wait_process(pid, exitcode=0)
  File "/buildbot/buildarea/3.10.pablogsal-arch-x86_64.asan_debug/build/Lib/test/support/__init__.py", line 1971, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 469963 is still running after 30.0 seconds

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants