bpo-45859: fix test_field_descriptor in test_collections for pypy #29691

cfbolz · 2021-11-21T20:49:12Z

that test tries to pickle the descriptors of a namedtuple's fields,
which is _collections._itemgetter on CPython. However, on PyPy that
class doesn't exist. The code in collections deals fine with that fact,
but the above-mentioned test does not make sense in that situation,
since you can't pickle properties.

https://bugs.python.org/issue45859

that test tries to pickle the descriptors of a namedtuple's fields, which is _collections._itemgetter on CPython. However, on PyPy that class doesn't exist. The code in collections deals fine with that fact, but the above-mentioned test does not make sense in that situation, since you can't pickle properties.

rhettinger · 2021-11-21T23:44:40Z

Perhaps just mark this test as CPython only.

cfbolz · 2021-11-22T08:32:18Z

works for me too, done!

miss-islington · 2021-11-22T14:45:00Z

Thanks @cfbolz for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

…only (pythonGH-29691) (cherry picked from commit 4fad314) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

bedevere-bot · 2021-11-22T14:45:16Z

GH-29708 is a backport of this pull request to the 3.10 branch.

bedevere-bot · 2021-11-22T14:45:24Z

GH-29709 is a backport of this pull request to the 3.9 branch.

miss-islington · 2021-11-22T14:47:23Z

Thanks @cfbolz for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington · 2021-11-22T14:47:23Z

Thanks @cfbolz for the PR, and @rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

…only (pythonGH-29691) (cherry picked from commit 4fad314) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

bedevere-bot · 2021-11-22T14:47:38Z

GH-29710 is a backport of this pull request to the 3.8 branch.

…only (GH-29691) (GH-29708) (cherry picked from commit 4fad314) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de> Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

…only (GH-29691) (GH-29709)

…only (pythonGH-29691)

…only (GH-29691) (GH-29710) (cherry picked from commit 4fad314) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

bedevere-bot · 2021-12-11T03:29:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.8 has failed when building commit 7c5b01b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/291/builds/55) and take a look at the build logs.
Check if the failure is related to this commit (7c5b01b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/291/builds/55

Failed tests:

test_nntplib

Failed subtests:

test_xover - test.test_nntplib.NetworkedNNTPTests
test_xhdr - test.test_nntplib.NetworkedNNTPTests
test_zzquit - test.test_nntplib.NetworkedNNTPTests
test_zlogin - test.test_nntplib.NetworkedNNTPTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

410 tests OK.

1 test failed:
test_nntplib

12 tests skipped:
test_asdl_parser test_clinic test_devpoll test_gdb test_ioctl
test_kqueue test_msilib test_startfile test_winconsoleio
test_winreg test_winsound test_zipfile64

1 re-run test:
test_nntplib

Total duration: 37 min 36 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 132, in test_xover
    resp, count, first, last, name = self.server.group(self.GROUP_NAME)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 663, in group
    resp = self._shortcmd('GROUP ' + name)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 227, in test_zlogin
    self.assertRaises(nntplib.NNTPError, self.server.login,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/unittest/case.py", line 816, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/unittest/case.py", line 202, in handle
    callable_obj(*args, **kwargs)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 964, in login
    resp = self._shortcmd('authinfo user ' + user)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 162, in test_xhdr
    resp, count, first, last, name = self.server.group(self.GROUP_NAME)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 663, in group
    resp = self._shortcmd('GROUP ' + name)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/test/test_nntplib.py", line 238, in test_zzquit
    self.server.quit()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 937, in quit
    resp = self._shortcmd('QUIT')
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.installed/build/target/lib/python3.8/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError

bedevere-bot · 2021-12-11T03:50:55Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.8 has failed when building commit 7c5b01b.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/324/builds/55) and take a look at the build logs.
Check if the failure is related to this commit (7c5b01b) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/324/builds/55

Failed tests:

test_nntplib

Failed subtests:

test_subinterpreter - test.test__xxsubinterpreters.IsRunningTests
test_xover - test.test_nntplib.NetworkedNNTPTests
test_zlogin - test.test_nntplib.NetworkedNNTPTests
test_xhdr - test.test_nntplib.NetworkedNNTPTests
test_zzquit - test.test_nntplib.NetworkedNNTPTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

413 tests OK.

10 slowest tests:

test_multiprocessing_spawn: 5 min 13 sec
test_concurrent_futures: 4 min 25 sec
test_smtpnet: 3 min 3 sec
test_lib2to3: 3 min
test_gdb: 2 min 54 sec
test_tokenize: 2 min 33 sec
test_tools: 2 min 31 sec
test_nntplib: 2 min 8 sec
test_asyncio: 2 min 1 sec
test_multiprocessing_forkserver: 1 min 42 sec

1 test failed:
test_nntplib

9 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

2 re-run tests:
test__xxsubinterpreters test_nntplib

Total duration: 35 min 42 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test__xxsubinterpreters.py", line 495, in test_subinterpreter
    self.assertTrue(interpreters.is_running(interp))
AssertionError: False is not true


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 162, in test_xhdr
    resp, count, first, last, name = self.server.group(self.GROUP_NAME)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 663, in group
    resp = self._shortcmd('GROUP ' + name)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 227, in test_zlogin
    self.assertRaises(nntplib.NNTPError, self.server.login,
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 816, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 202, in handle
    callable_obj(*args, **kwargs)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 964, in login
    resp = self._shortcmd('authinfo user ' + user)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 132, in test_xover
    resp, count, first, last, name = self.server.group(self.GROUP_NAME)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 663, in group
    resp = self._shortcmd('GROUP ' + name)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 932, in _bootstrap_inner
    self.run()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 870, in run
    self._target(*self._args, **self._kwargs)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test__xxsubinterpreters.py", line 51, in run
    interpreters.run_string(interp, dedent(f"""
RuntimeError: unrecognized interpreter ID 46


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 250, in wrapped
    meth(self)
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/test/test_nntplib.py", line 238, in test_zzquit
    self.server.quit()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 937, in quit
    resp = self._shortcmd('QUIT')
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 513, in _shortcmd
    return self._getresp()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 451, in _getresp
    resp = self._getline()
  File "/buildbot/buildarea/cpython/3.8.ware-gentoo-x86.nondebug/build/Lib/nntplib.py", line 439, in _getline
    if not line: raise EOFError
EOFError

cfbolz requested a review from rhettinger as a code owner November 21, 2021 20:49

the-knights-who-say-ni added the CLA signed label Nov 21, 2021

bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Nov 21, 2021

rhettinger added the skip news label Nov 21, 2021

rhettinger self-assigned this Nov 21, 2021

got with @cpython_only instead

428aa1b

rhettinger added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Nov 22, 2021

rhettinger merged commit 4fad314 into python:main Nov 22, 2021

bedevere-bot removed the awaiting review label Nov 22, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 22, 2021

bedevere-bot removed the needs backport to 3.9 only security fixes label Nov 22, 2021

rhettinger added needs backport to 3.8 needs backport to 3.9 only security fixes labels Nov 22, 2021

bedevere-bot removed the needs backport to 3.8 label Nov 22, 2021

rhettinger pushed a commit that referenced this pull request Nov 22, 2021

bpo-45859: Mark test_field_descriptor in test_collections as CPython-…

455ed45

…only (GH-29691) (GH-29709)

remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021

bpo-45859: Mark test_field_descriptor in test_collections as CPython-…

ba44c23

…only (pythonGH-29691)

ambv pushed a commit that referenced this pull request Dec 11, 2021

bpo-45859: Mark test_field_descriptor in test_collections as CPython-…

7c5b01b

…only (GH-29691) (GH-29710) (cherry picked from commit 4fad314) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>

terryjreedy removed the needs backport to 3.9 only security fixes label Feb 18, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-45859: fix test_field_descriptor in test_collections for pypy #29691

bpo-45859: fix test_field_descriptor in test_collections for pypy #29691

Uh oh!

cfbolz commented Nov 21, 2021 •

edited by bedevere-bot

Loading

Uh oh!

rhettinger commented Nov 21, 2021

Uh oh!

cfbolz commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

bedevere-bot commented Dec 11, 2021

Uh oh!

bedevere-bot commented Dec 11, 2021

Uh oh!

Uh oh!

Uh oh!

bpo-45859: fix test_field_descriptor in test_collections for pypy #29691

bpo-45859: fix test_field_descriptor in test_collections for pypy #29691

Uh oh!

Conversation

cfbolz commented Nov 21, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhettinger commented Nov 21, 2021

Uh oh!

cfbolz commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

miss-islington commented Nov 22, 2021

Uh oh!

bedevere-bot commented Nov 22, 2021

Uh oh!

bedevere-bot commented Dec 11, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Dec 11, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

cfbolz commented Nov 21, 2021 •

edited by bedevere-bot

Loading