Skip to content

docs: Improve example for urlparse() #29816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 2, 2021

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 27, 2021

http://docs.python.org:80/3/library/urllib.parse.html?highlight=params#url-parsing

Provide a more complete URL example to demonstrate the query and fragment members of ParseResult. Today's visitors to these docs are more used to complex URLs so it is better to quickly show them how urlparse() will segment the various parts including query and fragment.

Signed-off-by: Christian Clauss cclauss@me.com

Signed-off-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss force-pushed the better-examples-for-urlparse branch from c922c31 to 1d845e2 Compare November 28, 2021 11:17
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov asvetlov merged commit 226d22f into python:main Dec 2, 2021
@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2021
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <cclauss@me.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 2, 2021
@bedevere-bot
Copy link

GH-29888 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2021
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <cclauss@me.com>
@bedevere-bot
Copy link

GH-29889 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 2, 2021
@cclauss cclauss deleted the better-examples-for-urlparse branch December 2, 2021 09:39
asvetlov pushed a commit that referenced this pull request Dec 2, 2021
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <cclauss@me.com>
asvetlov pushed a commit that referenced this pull request Dec 2, 2021
(cherry picked from commit 226d22f)

Co-authored-by: Christian Clauss <cclauss@me.com>
domdfcoding added a commit to domdfcoding/cpython that referenced this pull request Apr 21, 2022
domdfcoding added a commit to domdfcoding/cpython that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants