Revert "bpo-28533: Remove asyncore, asynchat, smtpd modules (GH-29521)" #29951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR related to the SC decision: python/steering-council#86 |
warsaw
approved these changes
Dec 7, 2021
| @@ -176,7 +176,7 @@ partially finished requests and to use :mod:`selectors` to decide which | |||
| request to work on next (or whether to handle a new incoming request). This is | |||
| particularly important for stream services where each client can potentially be | |||
| connected for a long time (if threads or subprocesses cannot be used). See | |||
| :mod:`asyncio` for another way to manage this. | |||
| :mod:`asyncore` for another way to manage this. | |||
There was a problem hiding this comment.
Can't you still recommend asyncio even with the revert?
There was a problem hiding this comment.
Yes, it's possible, but I wanted to use a simple "git revert" command. Moreover, Miro wants to get it in 3.11.0a3, and Pablo suggests to merge the PR today, so I simply merged my PR.
vsajip
approved these changes
Dec 7, 2021
|
@pablogsal Can we please include this in 3.11.0a3? |
Yup, but let's make sure It's merged today. We have a bunch of release blockers anyway :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9bf2cbc.
https://bugs.python.org/issue28533