Skip to content

bpo-46004: Fix error location for loops with invalid targets #29959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2021
Merged

bpo-46004: Fix error location for loops with invalid targets #29959

merged 2 commits into from
Dec 7, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 7, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Dec 7, 2021
pablogsal
pablogsal commented Dec 7, 2021
View reviewed changes
@pablogsal pablogsal merged commit 1c7a1c3 into python:main Dec 7, 2021
@pablogsal pablogsal deleted the bpo-46004 branch December 7, 2021 13:02
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1c7a1c3be08ee911d347fffd2716f3911ba751f9 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Dec 7, 2021
@pablogsal
[3.10] bpo-46004: Fix error location for loops with invalid targets (p…
d43a358 
…ythonGH-29959).

(cherry picked from commit 1c7a1c3)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 7, 2021
@bedevere-bot
Copy link

GH-29961 is a backport of this pull request to the 3.10 branch.

pablogsal added a commit that referenced this pull request Dec 7, 2021
@pablogsal
[3.10] bpo-46004: Fix error location for loops with invalid targets (G…
c521412 
…H-29959). (GH-29961)

(cherry picked from commit 1c7a1c3)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni