Skip to content

Docs: Add note regarding "reversed" flag in heapq.merge #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2017
Merged

Docs: Add note regarding "reversed" flag in heapq.merge #300

merged 1 commit into from
Mar 5, 2017

Conversation

AdamNiederer
Copy link
Contributor

@AdamNiederer AdamNiederer commented Feb 25, 2017 •
edited
Loading

The docs for heapq.merge are a little ambiguous. Iterables passed
into heapq.merge with the reversed flag enabled must be sorted from
largest to smallest to achieve the desired sorting effect, but the
previous paragraph states that they should be sorted from smallest
to largest.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign the PSF contributor agreement. The "bugs.python.org username" requested by the form is the "Login name" field in "Your Details" at b.p.o
  2. Wait at least one US business day and then check the "Contributor form received entry under "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@AdamNiederer AdamNiederer force-pushed the master branch 2 times, most recently from e70a6f5 to 8792226 Compare February 26, 2017 17:16
@Carreau
Copy link
Contributor

Carreau commented Mar 3, 2017

Thanks Adam, I believe the core dev expect all Pull-Requests to be backed by an issue on http://bugs.python.org/ you might have to create one and link it from here.

+1 otherwise.

@rhettinger
Copy link
Contributor

I would think this would be obvious and it has never been a source of confusion. But I don't mind the additional wording.

@rhettinger rhettinger self-assigned this Mar 5, 2017
@rhettinger rhettinger self-requested a review March 5, 2017 05:03
rhettinger
rhettinger requested changes Mar 5, 2017
View reviewed changes
Copy link
Contributor

@rhettinger rhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To achieve similar behavior to" -> "To achieve behavior similar to"

@AdamNiederer
Docs: Add note regarding "reversed" flag in heapq.merge
a2779a0 
The docs for `heapq.merge` are a little misleading. Iterables passed
into heapq.merge with the reversed flag enabled must be sorted from
largest to smallest to achieve the desired sorting effect, but the
previous paragraph states that they should be sorted from smallest
to largest.
@rhettinger rhettinger merged commit b4e1b92 into python:master Mar 5, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Aug 8, 2021
Stackless issue python#300: correctly call audit hooks "sys.settrace"…
6fa9bf3 
… and "sys.setprofile"

- Don't call the audit hooks when switching tasklets.
- Add calls to tasklet_set_trace_function(),
  tasklet_set_profile_function() and tasklet_setstate().
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@dependabot-preview
Bump sentry-sdk from 0.13.4 to 0.13.5 (#300)
fc9b407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

Assignees

@rhettinger rhettinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamNiederer @the-knights-who-say-ni @Carreau @rhettinger @Mariatta