bpo-45919: Remove out of date comment #30090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @eryksun |
cf8d653 to
d3398f2
Compare
vstinner
reviewed
Dec 13, 2021
| Only use dup() on platforms where dup() is enough to detect invalid FD in | ||
| corner cases: on Linux and Windows (bpo-32849). | ||
| Only use dup() on Linux where dup() is enough to detect invalid FD | ||
| (bpo-32849). |
There was a problem hiding this comment.
On the "fcntl(fd, F_GETFD) is even faster, because it only checks the process table" comment, you can add that it is preferred over dup() when avaialble, since it cannot fail with the "too many open files" error (EMFILE).
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45919