Skip to content

bpo-46178: Remove/rename redundant Travis CI code #30309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 31, 2021
Merged

bpo-46178: Remove/rename redundant Travis CI code #30309

merged 1 commit into from
Dec 31, 2021

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 30, 2021 •
edited by bedevere-bot
Loading

Follow on from #30257, some extra Travis CI bits and bobs to remove or rename.

There's also a few extra places that added extra handling to catch random fails on Travis, I didn't touch those, but perhaps they could be reviewed/removed:

$ git grep -i travis
...
Lib/test/pythoninfo.py:            # for device" on Travis CI
Lib/test/pythoninfo.py:        "TRAVIS",
Lib/test/support/socket_helper.py:        # with EADDRNOTAVAIL on Travis CI
Lib/test/support/socket_helper.py:        # EADDRNOTAVAIL on Travis CI.
Lib/test/test_socket.py:                # [bpo-33937](https://bugs.python.org/issue33937) the test randomly fails on Travis CI with
Lib/test/test_socket.py:            # [bpo-33937](https://bugs.python.org/issue33937): catch also ENOMEM, the test randomly fails on Travis CI
...

https://bugs.python.org/issue46178

@hugovk hugovk mentioned this pull request Dec 30, 2021
Merged
Mariatta
Mariatta approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Mariatta Mariatta merged commit 2cf7d02 into python:main Dec 31, 2021
@bedevere-bot
Copy link

@Mariatta: Please replace # with GH- in the commit message next time. Thanks!

@hugovk hugovk deleted the rm-travis-ci branch December 31, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hugovk @bedevere-bot @Mariatta @the-knights-who-say-ni @AlexWaygood