Skip to content

bpo-46416: fix direct invocation of Lib/test/test_typing.py #30641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

bpo-46416: fix direct invocation of Lib/test/test_typing.py #30641

merged 2 commits into from
Jan 19, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jan 17, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jan 17, 2022
zware
zware reviewed Jan 17, 2022
View reviewed changes
@sobolevn sobolevn mentioned this pull request Jan 17, 2022
Merged
Fidget-Spinner
Fidget-Spinner approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait a day or two to see if Zach and others have any additional comments.

@sobolevn
Copy link
Member Author

sobolevn commented Jan 18, 2022 •
edited
Loading

I think that it might be a good idea to backport this to 3.9 and 3.10, because this is technically a bug fix, not an improvement 🙂

@sobolevn sobolevn mentioned this pull request Jan 18, 2022
Merged
@Fidget-Spinner Fidget-Spinner merged commit 2792d6d into python:main Jan 19, 2022
@Fidget-Spinner Fidget-Spinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 19, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @sobolevn and @Fidget-Spinner, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 2792d6d18eab3efeb71e6397f88db86e610541f1 3.9

@miss-islington
Copy link
Contributor

Sorry @sobolevn and @Fidget-Spinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2792d6d18eab3efeb71e6397f88db86e610541f1 3.10

@Fidget-Spinner
Copy link
Member

@sobolevn I suspect all your hard work refactoring our tests have made the auto backports fail 😆 . Would you like to send manual backports?

@Fidget-Spinner Fidget-Spinner removed needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 19, 2022
@sobolevn
Copy link
Member Author

sobolevn commented Jan 19, 2022 •
edited
Loading

Yes, it is the same as: #30666 🙂

@Fidget-Spinner
Copy link
Member

Great! Thank you, I'll check those out whenever you're ready.

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
@sobolevn
[3.9] bpo-46416: Allow direct invocation of Lib/test/test_typing.py (…
a65731f 
…pythonGH-30641)

Use `__name__`.
(cherry picked from commit 2792d6d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

Done:

sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
@sobolevn
[3.10] bpo-46416: Allow direct invocation of Lib/test/test_typing.py (
144c952 
pythonGH-30641)

Use `__name__`
(cherry picked from commit 2792d6d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Jan 19, 2022
@sobolevn
[3.9] bpo-46416: Allow direct invocation of Lib/test/test_typing.py (…
5107763 
…pythonGH-30641)

Use `__name__`.
(cherry picked from commit 2792d6d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

Update, this was my first time using cherry-picker. I got a bit confused about porting this PR to 3.9

But, turns test_special_attrs2 does not exist on 3.9: https://github.com/python/cpython/blob/3.9/Lib/test/test_typing.py

So, only 3.10 it is! Sorry for the noise!

Fidget-Spinner pushed a commit that referenced this pull request Jan 24, 2022
@sobolevn
[3.10] bpo-46416: Allow direct invocation of Lib/test/test_typing.py (
eaeb994 
GH-30641) (GH-30697)

Use `__name__`
(cherry picked from commit 2792d6d)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhadthedev arhadthedev arhadthedev left review comments

@zware zware zware approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Assignees

@Fidget-Spinner Fidget-Spinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sobolevn @miss-islington @Fidget-Spinner @arhadthedev @zware @the-knights-who-say-ni @bedevere-bot