Skip to content

bpo-46658: shutil Lib enabling sendfile on solaris systems as it supports #31165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-46658: shutil Lib enabling sendfile on solaris systems as it supports #31165

wants to merge 4 commits into from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Feb 6, 2022 •
edited by bedevere-bot
Loading

copy between file descriptors.

https://bugs.python.org/issue46658

@devnexen devnexen changed the title shutil Lib enabling sendfile on solaris systems as it supports bpo-46658: shutil Lib enabling sendfile on solaris systems as it supports Feb 6, 2022
JelleZijlstra
JelleZijlstra requested changes Feb 13, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this be tested?

From looking at test_shutil, it seems like it should run sendfile-based tests on Solaris automatically, but we don't run Solaris in normal CI. Perhaps we need to trigger the buildbots.

@devnexen devnexen mannequin mentioned this pull request Mar 28, 2024
Closed
@encukou
Copy link
Member

encukou commented Sep 19, 2024

Closing in favour of #23893.

@encukou encukou closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra requested changes

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devnexen @encukou @JelleZijlstra @the-knights-who-say-ni @ezio-melotti @bedevere-bot