Skip to content

[3.6] bpo-30121: Fix debug assert in subprocess on Windows (#1224) #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2017
Merged

[3.6] bpo-30121: Fix debug assert in subprocess on Windows (#1224) #3173

merged 2 commits into from
Aug 21, 2017
+59 −9

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Aug 21, 2017 •
edited by bedevere-bot
Loading

https://bugs.python.org/issue30121

segevfiner and others added 2 commits August 21, 2017 23:51
@segevfiner @vstinner
bpo-30121: Fix debug assert in subprocess on Windows (#1224)
a043bf1 
* bpo-30121: Fix debug assert in subprocess on Windows

This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.

* bpo-30121: Suppress debug assertion in test_subprocess when ran directly

(cherry picked from commit 4d38517)
@vstinner
Add test_subprocess.test_nonexisting_with_pipes() (#3133)
d4e183b 
bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
(cherry picked from commit 9a83f65)
@vstinner vstinner mentioned this pull request Aug 21, 2017
Merged
@vstinner vstinner merged commit e76cb43 into python:3.6 Aug 21, 2017
@vstinner vstinner deleted the subprocess_handle branch August 21, 2017 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot @segevfiner