bpo-40465: Document random module changes in 3.11 What's new #31818
Conversation
Doc/whatsnew/3.11.rst
Outdated
| random | ||
| ------ | ||
|
|
||
| * The *population* parameter of :func: `random.sample` must be a sequence. |
There was a problem hiding this comment.
This should fix the docs build:
| * The *population* parameter of :func: `random.sample` must be a sequence. | |
| * The *population* parameter of :func:`random.sample` must be a sequence. |
There was a problem hiding this comment.
It is not a correct place for this note because it is not a new feature. From user's point of view it is a breaking change which can break a code that worked before (even if it issued deprecation warnings). It should be documented in sections "Porting to Python 3.11", subsection "Changes in the Python API" or in section "Removed" (different changes may be in different sections).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Done: @hrnciar moved the What's New entry to Porting to Python 3.11 > Changes in the Python API. |
|
This change is related to 70a071d |
There was a problem hiding this comment.
Post-merge review (@serhiy-storchaka was faster than me :-)): LGTM! This change properly describes https://bugs.python.org/issue40465 changes.
|
BTW it was first time I used GitHub client for Android. |
https://bugs.python.org/issue40465