Skip to content

bpo-46948: Fix launcher installer build failure due to first part of fix #31920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 16, 2022

@zooba zooba added type-bug An unexpected behavior, bug, or error OS-windows needs backport to 3.7 needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Mar 16, 2022
@zooba zooba requested a review from a team as a code owner March 16, 2022 00:18
@zooba
Copy link
Member Author

zooba commented Mar 16, 2022

Skipping NEWS because we already have an entry for this issue number.

@zooba
Copy link
Member Author

zooba commented Mar 16, 2022

Manually confirmed that the issue is fixed in the CI build. (The changes to make the build actually fail are in issue47032.)

@zooba zooba merged commit 7088120 into python:main Mar 16, 2022
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-46948 branch March 16, 2022 00:46
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 16, 2022
@bedevere-bot
Copy link

GH-31922 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
…fix (pythonGH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Mar 16, 2022
@bedevere-bot
Copy link

GH-31923 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
…fix (pythonGH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-31924 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-31925 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
…fix (pythonGH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 16, 2022
…fix (pythonGH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Mar 16, 2022
…fix (GH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
miss-islington added a commit that referenced this pull request Mar 16, 2022
…fix (GH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
ned-deily pushed a commit that referenced this pull request Mar 16, 2022
…fix (GH-31920) (GH-31925)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
ambv pushed a commit that referenced this pull request Mar 16, 2022
…fix (GH-31920) (GH-31924)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…fix (pythonGH-31920)

(cherry picked from commit 7088120)

Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-windows skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants