gh-91214: Skip tests failing on Solaris #31978
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulikjak
commented
Mar 18, 2022
| @@ -3394,7 +3395,7 @@ def testCMSG_SPACE(self): | |||
| # Test CMSG_SPACE() with various valid and invalid values, | |||
| # checking the assumptions used by sendmsg(). | |||
| toobig = self.socklen_t_limit - socket.CMSG_SPACE(1) + 1 | |||
| values = list(range(257)) + list(range(toobig - 257, toobig)) | |||
| values = list(range(257)) + list(range(toobig - 257, toobig - 8)) | |||
There was a problem hiding this comment.
This is a 'fix' we are using internally, probably not acceptable (more in the issue tracker).
There was a problem hiding this comment.
What are the values of socklen_t_limit and socket.CMSG_SPACE(1) on Solaris?
There was a problem hiding this comment.
Well, I think that the simplest way to resolve this is to add Solaris-specific fix:
Suggested change
| values = list(range(257)) + list(range(toobig - 257, toobig - 8)) | |
| if SOLARIS: | |
| toobig -= 8 | |
| values = list(range(257)) + list(range(toobig - 257, toobig)) |
148436c to
c42f93b
Compare
c42f93b to
15d08ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should take Solaris worker closer to being green.
https://bugs.python.org/issue47058