Skip to content

gh-91266: refactor bytearray strip methods #32096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 14, 2022
Merged

gh-91266: refactor bytearray strip methods #32096

merged 8 commits into from
Apr 14, 2022

Conversation

eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Mar 24, 2022 •
edited by bedevere-bot
Loading

The bytearray strip, lstrip and rstrip methods contain duplicated code. This PR refactors the three implementations to use common code.

https://bugs.python.org/issue47110

@eendebakpt eendebakpt force-pushed the refactor/bytearray_strip branch from 1a70230 to 755c495 Compare March 25, 2022 09:39
MaxwellDupre
MaxwellDupre approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test Results:
415 tests OK.

8 tests failed:
test_asyncio test_bdb test_distutils test_embed test_idle
test_ossaudiodev test_peg_generator test_venv

Looks like none relevant.

@sweeneyde
Copy link
Member

The Python-visible API probably shouldn't change.

@eendebakpt
Copy link
Contributor Author

@sweeneyde Can you review again? Thanks

sweeneyde
sweeneyde approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@sweeneyde sweeneyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should typically be pretty conservative about refactoring PRs, but since this eliminates 45 lines, I think it makes sense.

@peendebak
Copy link
Contributor

@sweeneyde Thanks. Should I add a new entry for this?

@sweeneyde
Copy link
Member

Sure, yes: better to err on the side of documenting everything.

@eendebakpt eendebakpt changed the title bpo-47110: refactor bytearray strip methods gh-91266: refactor bytearray strip methods Apr 13, 2022
@eendebakpt @sweeneyde
Update Misc/NEWS.d/next/Core and Builtins/2022-04-13-07-14-30.gh-issu…
0474d6f 
…e-91266.6Vkzzt.rst

Co-authored-by: Dennis Sweeney <36520290+sweeneyde@users.noreply.github.com>
@sweeneyde sweeneyde merged commit 355cbaa into python:main Apr 14, 2022
@eendebakpt eendebakpt mannequin mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eendebakpt @sweeneyde @peendebak @MaxwellDupre @the-knights-who-say-ni @bedevere-bot