Skip to content

bpo-n/a: Updated ccbench.py used to assess multithreading #32135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Sophist-UK
Copy link

As used in faster-cpython/ideas#328.

Guido asked me to submit my changes as a PR so that the enhancements would be available to others.

Because this is not a PR on Python product code - but rather an update of an incidental performance measurement script - an issue number is not relevant.

As used in faster-cpython/ideas#328.

Guido asked me to submit my changes as a PR so that the enhancements would be available to others.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Sophist-UK

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Sophist-UK
Copy link
Author

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented in this PR that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

I believe it was clear from the faster-cpython/ideas#328 that the ccbench script is still useful - because it clearly identifies an ongoing performance issue when multithreading with one or more CPU-heavy threads, and indeed it was @gvanrossum Guido himself who requested this PR.

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated ccbench script for the pyperformance suite, so I guess it is going to just disappear.

@ericsnowcurrently
Copy link
Member

@hugovk ^^^

@hugovk
Copy link
Member

hugovk commented Feb 20, 2024

Thanks for the ping. Let's continue in the issue, I already replied to the identical comment there: #97680 (comment)

(And for completeness, there's also an identical comment at d.p.o.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants