Skip to content

bpo-47172: Make virtual opcodes negative. Make is_jump detect only actual jumps, use is_block_push for the exception block setup opcodes. #32200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 1, 2022
Merged

bpo-47172: Make virtual opcodes negative. Make is_jump detect only actual jumps, use is_block_push for the exception block setup opcodes. #32200

merged 12 commits into from
Apr 1, 2022

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 30, 2022 •
edited
Loading

@iritkatriel
bpo-47172: Make virtual opcodes > 256. Make is_jump detect only actua…
53f51f1 
…l jumps, use is_block_push for the exception block setup opcodes.
@iritkatriel iritkatriel changed the title bpo-47172: Make virtual opcodes > 256. Make is_jump detect only actua… bpo-47172: Make virtual opcodes > 256. Make is_jump detect only actual jumps, use is_block_push for the exception block setup opcodes. Mar 30, 2022
@iritkatriel iritkatriel mentioned this pull request Mar 30, 2022
Closed
brandtbucher
brandtbucher approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I have a few questions/suggestions:

brandtbucher
brandtbucher reviewed Mar 30, 2022
View reviewed changes
markshannon
markshannon reviewed Mar 31, 2022
View reviewed changes
Python/compile.c Outdated
#define SETUP_WITH 253
#define POP_BLOCK 252
#define JUMP 251
#define SETUP_FINALLY 256
Copy link
Member

@markshannon markshannon Mar 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an idea, but would it make sense for the virtual opcodes to be negative?
>0: Real
==0: Cache
<0: Virtual
It seems like a simpler scheme.

@iritkatriel iritkatriel changed the title bpo-47172: Make virtual opcodes > 256. Make is_jump detect only actual jumps, use is_block_push for the exception block setup opcodes. bpo-47172: Make virtual opcodes negative. Make is_jump detect only actual jumps, use is_block_push for the exception block setup opcodes. Mar 31, 2022
@iritkatriel iritkatriel mentioned this pull request Apr 1, 2022
Merged
markshannon
markshannon reviewed Apr 1, 2022
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of small suggestions

@markshannon
Copy link
Member

Thanks

@markshannon markshannon merged commit 997ba5d into python:main Apr 1, 2022
@iritkatriel iritkatriel deleted the sort_out_jumps_func branch April 1, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon left review comments

@brandtbucher brandtbucher brandtbucher approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@iritkatriel @markshannon @brandtbucher @raghavthind2005 @the-knights-who-say-ni @bedevere-bot