Skip to content

gh-91372: add mtime to gzip.open #32310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-91372: add mtime to gzip.open #32310

wants to merge 5 commits into from
+24 −4

Conversation

ellaellela
Copy link

@ellaellela ellaellela commented Apr 4, 2022 •
edited by bedevere-app bot
Loading

@AlexWaygood AlexWaygood added the type-feature A feature request or enhancement label Apr 4, 2022
MaxwellDupre
MaxwellDupre approved these changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 64 tests in 1.929s
OK (skipped=1)
Looks ok.

@carlbordum
Copy link
Contributor

Also looks good to me^

@ellaellela ellaellela mannequin mentioned this pull request Apr 10, 2022
Open
serhiy-storchaka
serhiy-storchaka requested changes Feb 23, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Feb 23, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@AlexWaygood AlexWaygood changed the title bpo-47216: add mtime to gzip.open gh-91372: add mtime to gzip.open Feb 23, 2024
@ellaellela
Copy link
Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Mar 30, 2024

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from serhiy-storchaka March 30, 2024 11:08
@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees
No one assigned
Labels
awaiting change review type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ellaellela @carlbordum @serhiy-storchaka @MaxwellDupre @the-knights-who-say-ni @ezio-melotti @bedevere-bot @AlexWaygood