Skip to content

[3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) (GH-3311) #3386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 6, 2017
Merged

[3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) (GH-3311) #3386

merged 4 commits into from
Sep 6, 2017

Conversation

zooba
Copy link
Member

@zooba zooba commented Sep 6, 2017 •
edited by bedevere-bot
Loading

@emmatyping
Copy link
Member

emmatyping commented Sep 6, 2017 •
edited
Loading

Im concerned about this change, as VS 2015 cannot build v141 binaries. I know v141 is binary compatible with v140, but shouldn't the VS version that builds Python stay consistent in a minor release? Or at least, shouldn't this be discussed more before this change is made? It requires the user to update VS which is a non-trivial change.

Ah, I see this seems to support both. Great!

@zooba
Copy link
Member Author

zooba commented Sep 6, 2017

@ethanhs It shouldn't require any update for existing users - VS 2015 can be used to build v140 binaries which are compatible with v141. This is why I explicitly enabled both versions of VS in AppVeyor.

@zooba
Copy link
Member Author

zooba commented Sep 6, 2017

But I did briefly forget about Tcl/Tk not supporting VS 2017 builds... guess we can't backport this change after all.

@zooba zooba closed this Sep 6, 2017
@emmatyping
Copy link
Member

@zooba thanks, "Change to building with MSVC v141" sounds like "replace v140 with v141" so I was concerned. Too bad this cannot be backported :(

@zooba zooba reopened this Sep 6, 2017
@zooba
Copy link
Member Author

zooba commented Sep 6, 2017

Trying again - I merged the fix for Tcl/Tk into master and merged it into this branch, so we should have success now.

@zooba zooba changed the title [3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) [3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) (#3311) Sep 6, 2017
@Mariatta Mariatta changed the title [3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) (#3311) [3.6] bpo-31340: Change to building with MSVC v141 (included with Visual Studio 2017) (GH-3311) Sep 6, 2017
@zooba zooba merged commit fd645ec into python:3.6 Sep 6, 2017
@zooba zooba deleted the bpo-31340-36 branch September 6, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @emmatyping @Mariatta @the-knights-who-say-ni @bedevere-bot