bpo-28556: Minor updates to typing module #3550
Merged
+38
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
reviewed
Sep 13, 2017
| @@ -0,0 +1,2 @@ | |||
| Minor updates to the ``typing`` module. Original PRs by Ivan Levkivskyi and | |||
There was a problem hiding this comment.
Instead of "Minor updates" can you describe what the updates are?
There was a problem hiding this comment.
They are quite technical: replacing _gorg function with a pre-calculated attribute, and adding one test that verifies preserved identity after copying a generic class. Should I add this?
There was a problem hiding this comment.
Instead of saying "Minor updates", say: "Speed improvements".
There was a problem hiding this comment.
Instead of saying "Minor updates", say: "Speed improvements".
OK, fixed.
|
Thanks @ilevkivskyi for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2017
* Copy changes to typing from upstream repo * Add NEWS entry (cherry picked from commit 65bc620)
|
GH-3558 is a backport of this pull request to the 3.6 branch. |
|
Thanks! ✨ 🍰 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains just two PRs:
This needs to be backported to 3.6
cc @gvanrossum
https://bugs.python.org/issue28556