bpo-28293: The regex cache no longer completely dump when full. #3768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warsaw
reviewed
Sep 27, 2017
| @@ -281,7 +288,10 @@ def _compile(pattern, flags): | |||
| p = sre_compile.compile(pattern, flags) | |||
| if not (flags & DEBUG): | |||
| if len(_cache) >= _MAXCACHE: | |||
| _cache.clear() | |||
| try: | |||
| _cache.popitem(False) | |||
There was a problem hiding this comment.
Sorry that I'm late to the game in reviewing this, and thanks for fixing this. One comment, should this be
_cache.popitem(last=False)
for readability? (I think if history had been different, we would have made that a keyword-only argument.)
There was a problem hiding this comment.
Maybe. This wouldn't harm performance, because sre_compile.compile() few lines above is much more expensive. Open a new PR for changing this if you will.
There was a problem hiding this comment.
I'm reworking my deferred compilation branch to add a new function, so I might just fold this simple change into that branch.
There was a problem hiding this comment.
Never mind; I'm abandoning the deferred compilation branch, so #3791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue28293